infrastructure/k8s-csi-s3
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity

Add 3 FIXMEs

Browse source
This commit is contained in:
Vitaliy Filippov 2021-07-19 17:17:51 +03:00
parent a0cf78dcbc
commit 55013c94bc
3 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
pkg/driver/controllerserver.go
View file

@ -125,6 +125,7 @@ func (cs *controllerServer) DeleteVolume(ctx context.Context, req *csi.DeleteVol
return nil, fmt.Errorf("failed to initialize S3 client: %s", err) return nil, fmt.Errorf("failed to initialize S3 client: %s", err)
} }
// FIXME Don't delete the bucket if it existed initially
var deleteErr error var deleteErr error
if prefix == "" { if prefix == "" {
// prefix is empty, we delete the whole bucket // prefix is empty, we delete the whole bucket

1
pkg/mounter/goofys.go
View file

@ -46,6 +46,7 @@ func (goofys *goofysMounter) Unstage(stageTarget string) error {
func (goofys *goofysMounter) Mount(source string, target string) error { func (goofys *goofysMounter) Mount(source string, target string) error {
fullPath := fmt.Sprintf("%s:%s", goofys.meta.BucketName, goofys.meta.Prefix) fullPath := fmt.Sprintf("%s:%s", goofys.meta.BucketName, goofys.meta.Prefix)
// FIXME Add memory limits
args := []string{ args := []string{
"--endpoint", goofys.endpoint, "--endpoint", goofys.endpoint,
"--region", goofys.region, "--region", goofys.region,

1
pkg/s3/client.go
View file

@ -168,6 +168,7 @@ func (client *s3Client) removeObjects(bucketName, prefix string) error {
} }
// will delete files one by one without file lock // will delete files one by one without file lock
// FIXME Delete in parallel (if we want to delete objects at all!)
func (client *s3Client) removeObjectsOneByOne(bucketName, prefix string) error { func (client *s3Client) removeObjectsOneByOne(bucketName, prefix string) error {
objectsCh := make(chan minio.ObjectInfo, 1) objectsCh := make(chan minio.ObjectInfo, 1)
removeErrCh := make(chan minio.RemoveObjectError, 1) removeErrCh := make(chan minio.RemoveObjectError, 1)