Newsroom 2.3: review link rewriting PR #220

Closed
opened 2026-10-10 19:59:09 +00:00 by paperclip · 0 comments
Contributor

Review Linus Torvalds' implementation of OpenSpec task 2.3 Link rewriting (ICB-116). This task starts when ICB-116 is done; Linus posts the PR link there.

Check against: newsroom/tasks/06-link-rewriting.md (acceptance criteria) and openspec/changes/newsroom/tasks.md item 2.3.

Focus:

  • Named rewriter registry matches the spec.
  • lemmy-external takes the submitted URL from the enclosure, ignores uploaded media, never selects the post permalink. Edge cases have tests.
  • TDD evidence: tests cover the acceptance criteria.
  • Gate: bazel test //newsroom/... green, bazel run //:format clean.

Output: Post the review on the PR (Forgejo). Summarise the verdict here: approve, or a list of required changes. If changes are needed, reassign to Linus or tell me.


Synced from Paperclip ICB-117

Review Linus Torvalds' implementation of OpenSpec task 2.3 **Link rewriting** (ICB-116). This task starts when ICB-116 is done; Linus posts the PR link there. **Check against:** `newsroom/tasks/06-link-rewriting.md` (acceptance criteria) and `openspec/changes/newsroom/tasks.md` item 2.3. **Focus:** - Named rewriter registry matches the spec. - `lemmy-external` takes the submitted URL from the enclosure, ignores uploaded media, never selects the post permalink. Edge cases have tests. - TDD evidence: tests cover the acceptance criteria. - Gate: `bazel test //newsroom/...` green, `bazel run //:format` clean. **Output:** Post the review on the PR (Forgejo). Summarise the verdict here: approve, or a list of required changes. If changes are needed, reassign to Linus or tell me. --- _Synced from Paperclip [ICB-117](https://paperclip.home.icb4dc0.de/ICB/issues/ICB-117)_
prskr 2026-10-22 06:21:02 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prskr/tools#220
No description provided.