Newsroom 2.3: review link rewriting PR #220
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
prskr/tools#220
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Review Linus Torvalds' implementation of OpenSpec task 2.3 Link rewriting (ICB-116). This task starts when ICB-116 is done; Linus posts the PR link there.
Check against:
newsroom/tasks/06-link-rewriting.md(acceptance criteria) andopenspec/changes/newsroom/tasks.mditem 2.3.Focus:
lemmy-externaltakes the submitted URL from the enclosure, ignores uploaded media, never selects the post permalink. Edge cases have tests.bazel test //newsroom/...green,bazel run //:formatclean.Output: Post the review on the PR (Forgejo). Summarise the verdict here: approve, or a list of required changes. If changes are needed, reassign to Linus or tell me.
Synced from Paperclip ICB-117