Re-review newsroom 6.1 PR #286 after fix round, with /code-review #288
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
prskr/tools#288
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Re-review PR #286 (newsroom 6.1 app wiring) after Linus Torvalds fixes B1–B3, N1 (SIGTERM) and possibly N2/N3 in ICB-162 (the blocker of this task). Use
/code-review. Re-run your earlier probes. Run the tests yourself without cached results, including the container integration tests. Post the verdict on this task and on the PR. Do not merge.NO SYMLINKS: never leave
bazel-*or any other symlink in the repo/workspace;find . -type l -not -path './.git/*'must print nothing before you finish.Source: conversation ICB-138, user comment 7108713c-d4e4-4491-8ea3-dd3469f81ecb. Previous review: ICB-160. Full plan is in this task's plan document.
Synced from Paperclip ICB-163