Short re-check of PR #286 after logging fix and nits (ICB-165), with /code-review #292
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
prskr/tools#292
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Short re-check of PR #286 (newsroom 6.1) after Linus Torvalds fixes your item 1 (slog default) and your nits in ICB-165 (the blocker of this task). Use
/code-reviewon his new commits after5979c3d. Run the tests yourself without cached results. Post the verdict on this task and on the PR. Do not merge.NO SYMLINKS: never leave
bazel-*or any other symlink in the repo/workspace;find . -type l -not -path './.git/*'must print nothing before you finish.Source: conversation ICB-138, user comment 81e4aa6d-b6f4-4552-9194-6e5ba24083b3. Previous review: ICB-163. Full plan is in this task's plan document.
Synced from Paperclip ICB-166