Short re-check of PR #286 after logging fix and nits (ICB-165), with /code-review #292

Closed
opened 2026-10-15 19:27:17 +00:00 by paperclip · 0 comments
Contributor

Short re-check of PR #286 (newsroom 6.1) after Linus Torvalds fixes your item 1 (slog default) and your nits in ICB-165 (the blocker of this task). Use /code-review on his new commits after 5979c3d. Run the tests yourself without cached results. Post the verdict on this task and on the PR. Do not merge.

NO SYMLINKS: never leave bazel-* or any other symlink in the repo/workspace; find . -type l -not -path './.git/*' must print nothing before you finish.

Source: conversation ICB-138, user comment 81e4aa6d-b6f4-4552-9194-6e5ba24083b3. Previous review: ICB-163. Full plan is in this task's plan document.


Synced from Paperclip ICB-166

Short re-check of PR #286 (newsroom 6.1) after Linus Torvalds fixes your item 1 (slog default) and your nits in ICB-165 (the blocker of this task). Use `/code-review` on his new commits after `5979c3d`. Run the tests yourself without cached results. Post the verdict on this task and on the PR. Do not merge. **NO SYMLINKS:** never leave `bazel-*` or any other symlink in the repo/workspace; `find . -type l -not -path './.git/*'` must print nothing before you finish. Source: conversation ICB-138, user comment 81e4aa6d-b6f4-4552-9194-6e5ba24083b3. Previous review: ICB-163. Full plan is in this task's plan document. --- _Synced from Paperclip [ICB-166](https://paperclip.home.icb4dc0.de/ICB/issues/ICB-166)_
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prskr/tools#292
No description provided.