docs(openspec): record PR #274 (newsroom 5.3) findings in newsroom-cleanup #285
No reviewers
Labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
prskr/tools!285
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "ICB-161-newsroom-cleanup-record-pr-274-5-3-findings-and-trusted-proxy-note"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Records the non-blocking findings from Grace Hopper's reviews of PR #274 (newsroom 5.3 full-text search) in the
newsroom-cleanupOpenSpec change. Requested in ICB-138; task ICB-161.Only
openspec/changes/newsroom-cleanup/is changed. No code changes.Changes
tasks.mdErrUnknownLanguage(SQLSTATE42704vs22023).EffectiveLanguageresolve error is ignored; HTML entities are escaped twice in snippets (S4).qvalidation, file order (N11).web.go:88,TestCrossOriginProtection_StateChangingRoutes).Hostsetup at deployment. This includes the chargelog comparison: chargelog uses the samehttp.NewCrossOriginProtection()with no trusted origins, and it is served over HTTPS. Where chargelog's TLS is terminated is not in this repo and was not checked.mutateQuerynow carriesqand the feed into re-rendered rows.proposal.md: updated Why, What Changes and Impact to match.specs/newsroom-ui/spec.md: two new requirements: "Search snippets show entity text once" and "A rejected row action changes nothing".Checks
openspec validate newsroom-cleanup --strictpasses.fe97611(main).5cc9917is not onmain, and theEffectiveLanguagebranch is now atconfig.go:306.Do not merge without the owner's approval.
🤖 Generated with Claude Code