docs(openspec): record PR #274 (newsroom 5.3) findings in newsroom-cleanup #285

Merged
prskr merged 1 commit from ICB-161-newsroom-cleanup-record-pr-274-5-3-findings-and-trusted-proxy-note into main 2026-10-15 11:54:03 +00:00
Contributor

Records the non-blocking findings from Grace Hopper's reviews of PR #274 (newsroom 5.3 full-text search) in the newsroom-cleanup OpenSpec change. Requested in ICB-138; task ICB-161.

Only openspec/changes/newsroom-cleanup/ is changed. No code changes.

Changes

tasks.md

  • New section 10 (5.3 review leftovers):
    • 10.1 MEDIUM: unknown language does not map to ErrUnknownLanguage (SQLSTATE 42704 vs 22023).
    • 10.2–10.4 LOW: 400 returned after the star/read change is already saved; EffectiveLanguage resolve error is ignored; HTML entities are escaped twice in snippets (S4).
    • 10.5–10.8 NIT: non-fatal loop guard in a test, stray blank lines, duplicate q validation, file order (N11).
  • 6.1 CSRF: marked done in PR #274 (web.go:88, TestCrossOriginProtection_StateChangingRoutes).
  • New 6.4: ask the owner again about the trusted proxy / Host setup at deployment. This includes the chargelog comparison: chargelog uses the same http.NewCrossOriginProtection() with no trusted origins, and it is served over HTTPS. Where chargelog's TLS is terminated is not in this repo and was not checked.
  • 1.1: note that mutateQuery now carries q and the feed into re-rendered rows.
  • 8.1: browser check also covers search rows and cross-origin behaviour behind the real proxy.

proposal.md: updated Why, What Changes and Impact to match.

specs/newsroom-ui/spec.md: two new requirements: "Search snippets show entity text once" and "A rejected row action changes nothing".

Checks

  • openspec validate newsroom-cleanup --strict passes.
  • No symlinks in the repo.
  • Line references in section 10 are from fe97611 (main). 5cc9917 is not on main, and the EffectiveLanguage branch is now at config.go:306.

Do not merge without the owner's approval.

🤖 Generated with Claude Code

Records the non-blocking findings from Grace Hopper's reviews of PR #274 (newsroom 5.3 full-text search) in the `newsroom-cleanup` OpenSpec change. Requested in ICB-138; task ICB-161. Only `openspec/changes/newsroom-cleanup/` is changed. No code changes. ## Changes **`tasks.md`** - New section 10 (5.3 review leftovers): - 10.1 MEDIUM: unknown language does not map to `ErrUnknownLanguage` (SQLSTATE `42704` vs `22023`). - 10.2–10.4 LOW: 400 returned after the star/read change is already saved; `EffectiveLanguage` resolve error is ignored; HTML entities are escaped twice in snippets (S4). - 10.5–10.8 NIT: non-fatal loop guard in a test, stray blank lines, duplicate `q` validation, file order (N11). - 6.1 CSRF: marked done in PR #274 (`web.go:88`, `TestCrossOriginProtection_StateChangingRoutes`). - New 6.4: ask the owner again about the trusted proxy / `Host` setup at deployment. This includes the chargelog comparison: chargelog uses the same `http.NewCrossOriginProtection()` with no trusted origins, and it is served over HTTPS. Where chargelog's TLS is terminated is not in this repo and was not checked. - 1.1: note that `mutateQuery` now carries `q` and the feed into re-rendered rows. - 8.1: browser check also covers search rows and cross-origin behaviour behind the real proxy. **`proposal.md`**: updated Why, What Changes and Impact to match. **`specs/newsroom-ui/spec.md`**: two new requirements: "Search snippets show entity text once" and "A rejected row action changes nothing". ## Checks - `openspec validate newsroom-cleanup --strict` passes. - No symlinks in the repo. - Line references in section 10 are from `fe97611` (`main`). `5cc9917` is not on `main`, and the `EffectiveLanguage` branch is now at `config.go:306`. Do not merge without the owner's approval. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
docs(openspec): record PR #274 (newsroom 5.3) findings in newsroom-cleanup
All checks were successful
Validate / validate (pull_request) Successful in 2m36s
Validate / validate (push) Successful in 2m31s
95a64f7b2e
Add task section 10 with the non-blocking findings from the 5.3
full-text search review, mark the CSRF check (6.1) as delivered in
PR #274, and add task 6.4 to ask the owner again about the trusted
proxy / Host setup at deployment, with the chargelog comparison.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
prskr approved these changes 2026-10-15 11:54:01 +00:00
prskr merged commit 95a64f7b2e into main 2026-10-15 11:54:03 +00:00
prskr deleted branch ICB-161-newsroom-cleanup-record-pr-274-5-3-findings-and-trusted-proxy-note 2026-10-15 11:54:04 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prskr/tools!285
No description provided.