docs(openspec): record PR #286 (newsroom 6.1) findings in newsroom-cleanup #290
No reviewers
Labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
prskr/tools!290
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "ICB-164-newsroom-cleanup-record-pr-286-6-1-findings-n4-and-nits"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Records the non-blocking findings from Grace Hopper's review of PR #286 (newsroom 6.1 app wiring, ICB-160, comment 17802 at
0c948f2) in thenewsroom-cleanupOpenSpec change. The owner asked for this in ICB-138 (comment7108713c-d4e4-4491-8ea3-dd3469f81ecb). Paperclip task: ICB-164.This PR does not depend on PR #286. It changes only
openspec/changes/newsroom-cleanup/and no code.Changes
tasks.md: new section 11, "App wiring (6.1) review leftovers (PR #286)":/admin/is not behindhttp.NewCrossOriginProtection(). Fix: wrap the/admin/subtree with the same check (one wrap, no bypass). Curl still works because it sends noOriginorSec-Fetch-Site. A test must show that a cross-site browser POST to/admin/ingest/{route}gets 403 and starts no ingest, and that a curl-style POST still works. This is linked to task 6.4 (trusted proxy /Host).http.ErrServerClosedcheck aftersrv.Shutdown.internal/healthis a near-copy of the content-extractor package, andCheckerFuncis not used. Move it to a sharedpkg/health, or at least remove the unused type.env:tags to thepkg/cliHTTP flags. This is shared code and affects chargelog, content-extractor and newsroom.specs/newsroom-operations/spec.md(new delta): ADDED requirement "Admin endpoints reject cross-site browser requests". It goes innewsroom-operations, notnewsroom-ui, because the admin subtree and the decision to run it without authentication are specified innewsroom-operations.proposal.md: Why, What Changes, Capabilities and Impact now include the 6.1 findings and the new code areas (cmd/newsroom,internal/health, sharedpkg/cli).B1–B3 and N1–N3 are not recorded here. They are being fixed on PR #286.
Checks
openspec validate newsroom-cleanup --strictpasses.find . -type l -not -path './.git/*'finds no symlinks.Do not merge without owner review.
🤖 Generated with Claude Code