docs(openspec): record PR #286 (newsroom 6.1) findings in newsroom-cleanup #290

Merged
prskr merged 1 commit from ICB-164-newsroom-cleanup-record-pr-286-6-1-findings-n4-and-nits into main 2026-10-15 19:29:58 +00:00
Contributor

Records the non-blocking findings from Grace Hopper's review of PR #286 (newsroom 6.1 app wiring, ICB-160, comment 17802 at 0c948f2) in the newsroom-cleanup OpenSpec change. The owner asked for this in ICB-138 (comment 7108713c-d4e4-4491-8ea3-dd3469f81ecb). Paperclip task: ICB-164.

This PR does not depend on PR #286. It changes only openspec/changes/newsroom-cleanup/ and no code.

Changes

  • tasks.md: new section 11, "App wiring (6.1) review leftovers (PR #286)":
    • 11.1 (LOW, N4): /admin/ is not behind http.NewCrossOriginProtection(). Fix: wrap the /admin/ subtree with the same check (one wrap, no bypass). Curl still works because it sends no Origin or Sec-Fetch-Site. A test must show that a cross-site browser POST to /admin/ingest/{route} gets 403 and starts no ingest, and that a curl-style POST still works. This is linked to task 6.4 (trusted proxy / Host).
    • 11.2: remove the dead http.ErrServerClosed check after srv.Shutdown.
    • 11.3: there are three serving-limit defaults. Keep one.
    • 11.4: internal/health is a near-copy of the content-extractor package, and CheckerFunc is not used. Move it to a shared pkg/health, or at least remove the unused type.
    • 11.5: add env: tags to the pkg/cli HTTP flags. This is shared code and affects chargelog, content-extractor and newsroom.
  • specs/newsroom-operations/spec.md (new delta): ADDED requirement "Admin endpoints reject cross-site browser requests". It goes in newsroom-operations, not newsroom-ui, because the admin subtree and the decision to run it without authentication are specified in newsroom-operations.
  • proposal.md: Why, What Changes, Capabilities and Impact now include the 6.1 findings and the new code areas (cmd/newsroom, internal/health, shared pkg/cli).

B1–B3 and N1–N3 are not recorded here. They are being fixed on PR #286.

Checks

  • openspec validate newsroom-cleanup --strict passes.
  • find . -type l -not -path './.git/*' finds no symlinks.

Do not merge without owner review.

🤖 Generated with Claude Code

Records the non-blocking findings from Grace Hopper's review of PR #286 (newsroom 6.1 app wiring, ICB-160, comment 17802 at `0c948f2`) in the `newsroom-cleanup` OpenSpec change. The owner asked for this in ICB-138 (comment `7108713c-d4e4-4491-8ea3-dd3469f81ecb`). Paperclip task: ICB-164. This PR does not depend on PR #286. It changes only `openspec/changes/newsroom-cleanup/` and no code. ## Changes - `tasks.md`: new section 11, "App wiring (6.1) review leftovers (PR #286)": - 11.1 (LOW, N4): `/admin/` is not behind `http.NewCrossOriginProtection()`. Fix: wrap the `/admin/` subtree with the same check (one wrap, no bypass). Curl still works because it sends no `Origin` or `Sec-Fetch-Site`. A test must show that a cross-site browser POST to `/admin/ingest/{route}` gets 403 and starts no ingest, and that a curl-style POST still works. This is linked to task 6.4 (trusted proxy / `Host`). - 11.2: remove the dead `http.ErrServerClosed` check after `srv.Shutdown`. - 11.3: there are three serving-limit defaults. Keep one. - 11.4: `internal/health` is a near-copy of the content-extractor package, and `CheckerFunc` is not used. Move it to a shared `pkg/health`, or at least remove the unused type. - 11.5: add `env:` tags to the `pkg/cli` HTTP flags. This is shared code and affects chargelog, content-extractor and newsroom. - `specs/newsroom-operations/spec.md` (new delta): ADDED requirement "Admin endpoints reject cross-site browser requests". It goes in `newsroom-operations`, not `newsroom-ui`, because the admin subtree and the decision to run it without authentication are specified in `newsroom-operations`. - `proposal.md`: Why, What Changes, Capabilities and Impact now include the 6.1 findings and the new code areas (`cmd/newsroom`, `internal/health`, shared `pkg/cli`). B1–B3 and N1–N3 are not recorded here. They are being fixed on PR #286. ## Checks - `openspec validate newsroom-cleanup --strict` passes. - `find . -type l -not -path './.git/*'` finds no symlinks. Do not merge without owner review. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
docs(openspec): record PR #286 (newsroom 6.1) findings in newsroom-cleanup
All checks were successful
Validate / validate (pull_request) Successful in 2m32s
Validate / validate (push) Successful in 2m16s
44c1094b88
Add task 11 with N4 (/admin/ outside cross-origin protection) and the
non-blocking wiring nits from the PR #286 review (ICB-160). Add a
newsroom-operations delta: admin endpoints reject cross-site browser
requests and still serve non-browser clients.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
prskr approved these changes 2026-10-15 19:29:55 +00:00
prskr merged commit 44c1094b88 into main 2026-10-15 19:29:58 +00:00
prskr deleted branch ICB-164-newsroom-cleanup-record-pr-286-6-1-findings-n4-and-nits 2026-10-15 19:29:58 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prskr/tools!290
No description provided.