docs(openspec): record PR #286 re-review items 2–6 in newsroom-cleanup #294

Contributor

Records the non-blocking items 2–6 from Grace Hopper's re-review of PR #286 (ICB-163, PASS at 5979c3d, #286 (comment)) in the newsroom-cleanup OpenSpec change. Requested by the owner in ICB-138 (comment 81e4aa6d-b6f4-4552-9194-6e5ba24083b3). Paperclip task: ICB-167.

Docs only. Only openspec/changes/newsroom-cleanup/ is changed. Independent of PR #286 (item 1 and the re-review nits are fixed there, ICB-165). Do not merge without review.

Changes

  • tasks.md: new section 12 — App wiring (6.1) re-review leftovers (PR #286)
    • 12.1 (LOW) shutdown is not hard-bounded when a run ignores ctx; a second signal is swallowed
    • 12.2 (LOW) readiness stays 200 during the drain window; route trigger gives 500 instead of 503
    • 12.3 (NIT) passwordEnv is rejected in the CLI, not in config.Validate; ?user= question
    • 12.4 (NIT) ErrNoLLMBaseURL reported once per summarizing provider
    • 12.5 (NIT) backfill job registered even when no provider summarizes
    • Line refs are from 5979c3d (branch paperclip/ICB-159-app-wiring) and may move after ICB-165.
  • proposal.md: Why, What Changes, Capabilities and Impact updated for task 12.
  • specs/newsroom-operations/spec.md (new): ADDED requirements "Readiness reports not-ready during shutdown" and "Shutdown is bounded even if work ignores cancellation".

Conflict with PR #290 (section 11)

PR #290 (ICB-164) is still open and adds section 11. This PR uses section 12 anyway. Whichever PR merges second needs a small rebase:

  • tasks.md: keep section 11 before section 12.
  • proposal.md: keep both sentences in Why, both bullets in What Changes, one newsroom-operations capability line (merge both texts), and merge the Impact lines.
  • specs/newsroom-operations/spec.md: both PRs create this file (add/add conflict). Keep one ## ADDED Requirements header with all three requirements.

Checks

  • openspec validate newsroom-cleanup --strict: valid
  • find . -type l -not -path './.git/*': no output

🤖 Generated with Claude Code

Records the non-blocking items 2–6 from Grace Hopper's re-review of PR #286 (ICB-163, PASS at `5979c3d`, https://code.icb4dc0.de/prskr/tools/pulls/286#issuecomment-17812) in the `newsroom-cleanup` OpenSpec change. Requested by the owner in ICB-138 (comment `81e4aa6d-b6f4-4552-9194-6e5ba24083b3`). Paperclip task: ICB-167. Docs only. Only `openspec/changes/newsroom-cleanup/` is changed. Independent of PR #286 (item 1 and the re-review nits are fixed there, ICB-165). **Do not merge without review.** ## Changes - `tasks.md`: new **section 12 — App wiring (6.1) re-review leftovers (PR #286)** - 12.1 (LOW) shutdown is not hard-bounded when a run ignores ctx; a second signal is swallowed - 12.2 (LOW) readiness stays 200 during the drain window; route trigger gives 500 instead of 503 - 12.3 (NIT) `passwordEnv` is rejected in the CLI, not in `config.Validate`; `?user=` question - 12.4 (NIT) `ErrNoLLMBaseURL` reported once per summarizing provider - 12.5 (NIT) backfill job registered even when no provider summarizes - Line refs are from `5979c3d` (branch `paperclip/ICB-159-app-wiring`) and may move after ICB-165. - `proposal.md`: Why, What Changes, Capabilities and Impact updated for task 12. - `specs/newsroom-operations/spec.md` (new): ADDED requirements "Readiness reports not-ready during shutdown" and "Shutdown is bounded even if work ignores cancellation". ## Conflict with PR #290 (section 11) PR #290 (ICB-164) is still open and adds section 11. This PR uses **section 12** anyway. Whichever PR merges second needs a small rebase: - `tasks.md`: keep section 11 before section 12. - `proposal.md`: keep both sentences in Why, both bullets in What Changes, one `newsroom-operations` capability line (merge both texts), and merge the Impact lines. - `specs/newsroom-operations/spec.md`: both PRs create this file (add/add conflict). Keep one `## ADDED Requirements` header with all three requirements. ## Checks - `openspec validate newsroom-cleanup --strict`: valid - `find . -type l -not -path './.git/*'`: no output 🤖 Generated with [Claude Code](https://claude.com/claude-code)
docs(openspec): record PR #286 re-review items 2-6 in newsroom-cleanup
All checks were successful
Validate / validate (pull_request) Successful in 2m33s
0a6725c4b7
Adds section 12 (shutdown hard bound, readiness during drain,
passwordEnv validation, ErrNoLLMBaseURL once, backfill registration)
and a newsroom-operations spec delta.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merge main (PR #290, section 11) into ICB-167 branch
All checks were successful
Validate / validate (pull_request) Successful in 2m37s
a227a428c0
Resolve conflicts in newsroom-cleanup: keep section 11 before 12,
merge proposal Why/What Changes/Capabilities/Impact, and keep one
ADDED header with all three newsroom-operations requirements.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
prskr approved these changes 2026-10-16 06:52:24 +00:00
prskr merged commit fff83f3daa into main 2026-10-16 06:52:36 +00:00
prskr deleted branch ICB-167-newsroom-cleanup-record-pr-286-re-review-items-2-6-shutdown-readiness-config-checks 2026-10-16 06:52:36 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prskr/tools!294
No description provided.